fix: omit trailing next_placeholder increment after last param#15
Merged
fix: omit trailing next_placeholder increment after last param#15
Conversation
The generated slice-replacement code ended with `next_placeholder += slice_len` (or `+= 1`) even when no further params followed, producing a dead store that triggered `unused_assignments` in downstream crates. Emit the increment only for non-final params, and drop `mut` on the counter when there is a single param. Also skip the declaration entirely for zero-param queries.
jrandolf
added a commit
that referenced
this pull request
Apr 22, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.7](v0.1.6...v0.1.7) (2026-04-22) ### Bug Fixes * Omit trailing next_placeholder increment after last param ([#15](#15)) ([6bb1b7e](6bb1b7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next_placeholder += slice_len(or+= 1) even for the final param, producing a dead store that tripsunused_assignmentsin downstream crates.mutwhen there is a single param; skip the declaration entirely for zero-param queries.Test plan
cargo test(snapshot + postgres integration)