✨ Add GLWpfControl to SceneView#243
Merged
mathew-odwyer merged 6 commits intoepic/112-editorfrom Aug 12, 2023
Merged
Conversation
mathew-odwyer
commented
Aug 12, 2023
Owner
Author
mathew-odwyer
left a comment
There was a problem hiding this comment.
Almost good to merge.
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Aug 12, 2023
Merged
GLWpfControl to SceneViewGLWpfControl to SceneView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
GLWpfControltoSceneViewSceneRendererservice to handle rendering of scenes (currently it just clears the view to a dark color).GLWpfControlNuGet package until the official package can be updated:PackageReferencefrom 4.7.5 to 4.8.0. opentk/GLWpfControl#115WeakReferenceMessengerfrom the IoC container as we're not using it.Fixes #242
Dependencies
Type of change
How Has This Been Tested?
I added unit tests to accommodate my changes as well as ensured that a simple triangle could be rendered using immediate mode OpenGL (this has been removed as it's not a requirement for the issue). I also made sure that events were still being triggered by the main application as originally there were some issues but it looks like they've been resolved.
Test Configuration:
Proposed Design
Scene Renderer
The scene renderer is responsible for rendering the currently active scene. Right now it simply clears the view to a dark color. You should not but any game-update logic in here. This can instead be handled by the
SceneViewPaneViewModelwith some other service if required.Checklist: