Game Scripts: Persona 5 Royal, Ys IX: Monstrum Nox#24
Open
ShadowVolt wants to merge 6 commits intomathewthe2:mainfrom
Open
Game Scripts: Persona 5 Royal, Ys IX: Monstrum Nox#24ShadowVolt wants to merge 6 commits intomathewthe2:mainfrom
ShadowVolt wants to merge 6 commits intomathewthe2:mainfrom
Conversation
thanks to Jo-Mako, I was made aware that my old version of this script was missing more than half of the text. With their help, I was able to get everything that was missing, and re-parse it all.
meticulously parsed using a custom python script: - removed duplicate lines - preserved duplicate character name lines - kept positions of line breaks so that each dialogue box corresponds to its own visual section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope you've been well since the last time I was around these parts; things have been busy for sure.
What promped this pull was that I happened to see issue #11 while I was dusting off my github account, in turn reminding me that I worked on a P5R script to go with my original P5 one back when the PC version first released, and that I have been sitting on it for the last several months. The other one was the last thing I worked on back when I was still active here, but hadn't made a PR for yet. Never did get around to testing it though.
Also merges an old commit of mine that fixes a glaring mistake in my original P5 script. See 07aad6c for details.
Persona 5 Royal
Based on a dump of the switch version; heavily parsed to remove all duplicate lines, aside from the character name popups. Had to write a short parsing script using (very amateur) python to catch all the edge-cases, since my typical brute-force regex approach failed to preserve the names or the whitespace in such a way that kept it readable by eye without removing anything important.
Ys IX: Monstrum Nox
Frankly, I don't remember much about this script, given that I didn't leave any notes about how I made it and that I never ended up properly testing it in the end. But as far as I know it is indeed complete, so maybe a potential translator out there might find this interesting? Who knows?