capturing the training set in a closure to avoid retraining for each …#6
Open
alexzubiaga wants to merge 1 commit intomathias-brandewinder:masterfrom
Open
capturing the training set in a closure to avoid retraining for each …#6alexzubiaga wants to merge 1 commit intomathias-brandewinder:masterfrom
alexzubiaga wants to merge 1 commit intomathias-brandewinder:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that it's been a while since you updated this repo, but It's helped me so much to grasp ML concepts that I had to contribute back.
In my experiments with the Bayes clasificator I noticed very fast training times, but extremely slow clasification times. As it turned out due to the lazy Seq evaluation I was retraining the whole model for each entry from my test set.
This can be avoided by capturing the model in a closure.
Many Thanks for this great code!