feat(element-call url params): split url params into configuration and properties #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5560 will not alter performanceComparing Summary
|
toger5
force-pushed
the
toger5/intent-system-call-url
branch
3 times, most recently
from
e1c1764 to
ef6890a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5560 +/- ##
==========================================
- Coverage 88.96% 88.95% -0.01%
==========================================
Files 335 335
Lines 93261 93257 -4
Branches 93261 93257 -4
==========================================
- Hits 82966 82956 -10
- Misses 6438 6443 +5
- Partials 3857 3858 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 21, 2025
toger5
force-pushed
the
toger5/intent-system-call-url
branch
from
4d9cb43 to
2f5911f
Compare
Hywan
requested changes
Aug 27, 2025
Use two structs one for configuration and one for required properties instead of mixing them. Signed-off-by: Timo K <toger5@hotmail.de>
Signed-off-by: Timo K <toger5@hotmail.de>
toger5
force-pushed
the
toger5/intent-system-call-url
branch
from
2f5911f to
f007b20
Compare
Hywan
approved these changes
Sep 2, 2025
| @@ -44,13 +44,13 @@ struct ElementCallParams { | |||
| /// compatibility. Set to `true` if intent is `Intent::StartCall`. | |||
| skip_lobby: Option<bool>, | |||
| confine_to_room: bool, | |||
| app_prompt: bool, | |||
| app_prompt: Option<bool>, | |||
There was a problem hiding this comment.
What Option<bool> means here? Specifically, how Some(false) is different from None?
| @@ -59,7 +59,7 @@ struct ElementCallParams { | |||
| font_scale: Option<f64>, | |||
| font: Option<String>, | |||
| #[serde(rename = "perParticipantE2EE")] | |||
| per_participant_e2ee: bool, | |||
| per_participant_e2ee: Option<bool>, | |||
| /// Deprecated since Element Call v0.13.0. Included for backwards | ||
| /// compatibility. Use header: "standard"|"none" instead. | ||
| hide_header: Option<bool>, | ||
| preload: bool, | ||
| preload: Option<bool>, |
| hide_screensharing: bool, | ||
| controlled_media_devices: bool, | ||
| /// Supported since Element Call v0.9.0. | ||
| hide_screensharing: Option<bool>, |
| @@ -195,6 +191,53 @@ pub struct VirtualElementCallWidgetOptions { | |||
| /// Default: `true` | |||
| pub confine_to_room: Option<bool>, | |||
|
|
|||
| /// Do not show the screenshare button. | |||
| pub hide_screensharing: Option<bool>, | |||
|
|
||
| /// Make the audio devices be controlled by the os instead of the | ||
| /// element-call webview. | ||
| pub controlled_audio_devices: Option<bool>, |
| /// The font scale which will be used inside element call. | ||
| /// | ||
| /// Default: `1` | ||
| pub font_scale: Option<f64>, |
There was a problem hiding this comment.
What happens if it's 0? Is it allowed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of an onging effort to move responsiblity to the EC app and out of the EX apps.
4 intends (f.ex
join_existingstart_new_dm... ) (as url paramters) are introduced in recent element call versions. Those intends behave like defaults. If an intend is set a set of url parameters are predefined.Not all params can be covered by the intend (for insteance the
widget_idor thehost_url).This PR splits the url parameters into configuration (things that can be configured by the intent) and properties (things that still need to be passed one by one)
The goal with this change is that EX only needs to configre the intent once and the EC codebase can update the behavior in those 4 specific scenarios in case new features come along (auto hangup when other participants leave, send call ring notification...)
Signed-off-by: Timo K toger5@hotmail.de
Signed-off-by: