Skip to content

Conversation

davidegirardi
Copy link

Add a command to create encrypted rooms. There's a bit of duplicate code from the CreateRoom mode but I think it's ok. Open to comments of course.

@davidegirardi davidegirardi requested a review from a team as a code owner September 3, 2025 08:36
@davidegirardi davidegirardi requested review from andybalaam and removed request for a team September 3, 2025 08:36
@davidegirardi davidegirardi changed the title Add create encrypted room Multiverse: add create encrypted room Sep 3, 2025
@davidegirardi davidegirardi requested review from poljar and removed request for andybalaam September 3, 2025 08:37
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.89%. Comparing base (1f2b4f8) to head (c38a9f4).
⚠️ Report is 24 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5615   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         345      345           
  Lines       95800    95800           
  Branches    95800    95800           
=======================================
+ Hits        85158    85165    +7     
+ Misses       6655     6647    -8     
- Partials     3987     3988    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #5615 will improve performances by 48.14%

Comparing davidegirardi:dg/multiverse-create-encrypted-room (c38a9f4) with main (472b934)

Summary

⚡ 1 improvements
✅ 48 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Restore session [memory store] 403.3 ms 272.2 ms +48.14%

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this approach is completely fine for a hackaton, I think we'll want to reuse the existing command and view to be able to pick if a room should be encrypted or not.

Basically we'll want to recreate what Element or other real clients do:

image

A, by default on, toggle switch to enable/disable encryption in the room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants