Skip to content

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Sep 3, 2025

Otherwise, when running against a server that doesn't support thread subscriptions, the client may falsely think that its thread subscriptions are not outdated (when receiving an empty, defaulted ThreadSubscriptions section in the SSS response). As a result, it would always use the store, not find most thread subscriptions, and conclude "nope, you haven't subscribed to any thread", which is wrong.

(Looking for support of MSC4306 is close to what we want, which would be support of MSC4308 itself, coming as part of element-hq/synapse#18695, and that will land despite MSC4306 being already advertised, but that's good enough, since it's unlikely many servers have enabled it by default yet.)

@bnjbvr bnjbvr requested a review from a team as a code owner September 3, 2025 10:44
@bnjbvr bnjbvr requested review from poljar and removed request for a team September 3, 2025 10:44
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.87%. Comparing base (472b934) to head (ae4ce6e).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/room_list_service/mod.rs 41.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5618      +/-   ##
==========================================
- Coverage   88.88%   88.87%   -0.01%     
==========================================
  Files         348      348              
  Lines       96437    96443       +6     
  Branches    96437    96443       +6     
==========================================
- Hits        85718    85715       -3     
- Misses       6682     6689       +7     
- Partials     4037     4039       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #5618 will improve performances by 48.07%

Comparing bnjbvr/gate-tsub-extension-on-server-feature (ae4ce6e) with main (472b934)

Summary

⚡ 1 improvements
✅ 48 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Restore session [memory store] 403.3 ms 272.4 ms +48.07%

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Would love to get a test for that, it seems sensitive, thought?

@poljar poljar removed their request for review September 4, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants