fix(room service): enable the thread subscriptions extension based on server support #5618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when running against a server that doesn't support thread subscriptions, the client may falsely think that its thread subscriptions are not outdated (when receiving an empty, defaulted
ThreadSubscriptions
section in the SSS response). As a result, it would always use the store, not find most thread subscriptions, and conclude "nope, you haven't subscribed to any thread", which is wrong.(Looking for support of MSC4306 is close to what we want, which would be support of MSC4308 itself, coming as part of element-hq/synapse#18695, and that will land despite MSC4306 being already advertised, but that's good enough, since it's unlikely many servers have enabled it by default yet.)