Skip to content

perf: precompute the room notification modes only if push rules have changed #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: precompute the room notification modes only if push rules have changed #5621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20bdcd
perf: precompute the room notification modes if and only if push rule…
bnjbvr Sep 3, 2025
5ea16b9
fixup! perf: precompute the room notification modes if and only if pu…
bnjbvr Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions crates/matrix-sdk/src/sliding_sync/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ use matrix_sdk_base::{
sync::SyncResponse, timer, RequestedRequiredStates, ThreadSubscriptionCatchupToken,
};
use matrix_sdk_common::deserialized_responses::ProcessedToDeviceEvent;
use ruma::api::{
client::sync::sync_events::v5::{self as http, response},
FeatureFlag, SupportedVersions,
use ruma::{
api::{
client::sync::sync_events::v5::{self as http, response},
FeatureFlag, SupportedVersions,
},
events::GlobalAccountDataEventType,
};
use tracing::error;

Expand Down Expand Up @@ -242,13 +245,25 @@ impl SlidingSyncResponseProcessor {
async fn update_in_memory_caches(client: &Client, response: &SyncResponse) -> Result<()> {
let _timer = timer!(tracing::Level::TRACE, "update_in_memory_caches");

for room_id in response.rooms.joined.keys() {
let Some(room) = client.get_room(room_id) else {
error!(?room_id, "Cannot post process a room in sliding sync because it is missing");
continue;
};

room.user_defined_notification_mode().await;
// Only update the notification modes if the push rules have changed.
if response.account_data.iter().any(|event| {
event
.get_field::<GlobalAccountDataEventType>("type")
.ok()
.flatten()
.is_some_and(|event_type| event_type == GlobalAccountDataEventType::PushRules)
}) {
for room_id in response.rooms.joined.keys() {
let Some(room) = client.get_room(room_id) else {
error!(
?room_id,
"Cannot post process a room in sliding sync because it is missing"
);
continue;
};

room.user_defined_notification_mode().await;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: an extra perf improvement would be to create the NotificationSettings instance once (instead of once per call to user_defined_notification_mode()), and use it to update all the room notification modes at once, instead of creating the NotificationSettings (which loads the push rules from DB) once per room.

Also, I think it's still necessary to figure what are the newly joined rooms, and compute the user defined notification mode for those.

Not as simple as I imagined first, unfortunately.

}
}

Ok(())
Expand Down
Loading