chore: Remove the old Latest Event API

[Hywan]

This set of patches remove the old latest event API, since the new one is now available and working.

Finally, this set of patches also remove the new_ prefix from the new latest event API.

🎉

---

• Address [meta] Latest Event API, the missing one #4112

[codecov]

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.81%. Comparing base (412d4b8) to head (31e3911).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-base/src/room/room_info.rs	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5624      +/-   ##
==========================================
- Coverage   88.88%   88.81%   -0.07%     
==========================================
  Files         348      346       -2     
  Lines       96483    94858    -1625     
  Branches    96483    94858    -1625     
==========================================
- Hits        85757    84252    -1505     
+ Misses       6687     6584     -103     
+ Partials     4039     4022      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codspeed-hq]

CodSpeed Performance Report

Merging #5624 will not alter performance

_{Comparing Hywan:chore-remove-old-latest-event-api (31e3911) with main (f9b4190)}

Summary

✅ 49 untouched benchmarks

[poljar]

This depends on #5617, right?

[Hywan]

There are orthogonal. #5617 is adding a new feature to the new Latest Event API, while this set of patches removes the old API.

The last patch of this set introduce a renaming by removing the new_ prefix. It can conflict with #5617, but it's not a big deal.

[poljar]

I think this looks fine, though it should only be merged after #5617 is merged, otherwise we're regressing in functionality.

This is also missing a changelog entry.

[Hywan]

#5617 can be merged after this PR, it won't add any regression. Right now, with the old Latest Event API was not supporting local events, so it was impossible to sort by them.

However, #3872 must be addressed so that re-decryption happens in the Event Cache. The old Latest Event API has its own re-decryption mechanism. Knowing that the new Latest Event API relies on the Event Cache, as long as the Event Cache doesn't support redecryption, we will have a regression.

So:

• Event cache: Move decryption retry in there #3872 must be addressed before merging this PR,
• feat(ui): Add the new latest_event room list sorter, and update the recency sorter #5617 can be merged at anytime.

[poljar]

#5617 can be merged after this PR, it won't add any regression. Right now, with the old Latest Event API was not supporting local events, so it was impossible to sort by them.

Ah, because #5587 added the new way to do latest events, and #5617 will only do the sorting based on the latest event.

Right, sorry for being confused.