Fix: PostmessageTransport are leaking as they keep listening to window events when stopped #155
+90
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
valere/fix_message_transport_leak
branch
from
cd03f1d to
1f9ed4d
Compare
|
Half-Shot
approved these changes
Jan 13, 2026
| @@ -0,0 +1,86 @@ | |||
| /* | |||
| * Copyright 2025 The Matrix.org Foundation C.I.C. | |||
| @@ -1,2 +1,2 @@ | |||
| /* | |||
| * Copyright 2020 - 2024 The Matrix.org Foundation C.I.C. | |||
Contributor
There was a problem hiding this comment.
🌈 It's a brand new year!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostmessageTransport is calling
inboundWindow.addEventListeneron start, but it is never callinginboundWindow.removeEventListener.