-
Notifications
You must be signed in to change notification settings - Fork 376
Feat/header refactoring #2889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/header refactoring #2889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for context: the referenced issue predates my involvement)
the button shape should probably remain aligned with the rest of the website (e.g. the homepage).
the direction of the dropdown arrows seems odd to me.
the animation of the dropdown arrows does not match the menu appearing on desktop.
this is how it looks for me. a bit of vshift in any text is "expected" since i don't have helvetica.
what do you think about re-adjusting the media queries to match the new header "width" more closely? similar to how we expanded them when we added the homeserver section in https://github.com/matrix-org/matrix.org/pull/2818/files#diff-0482eaf67dabfe24441fa69f3d1e754089479ce3c572f586b57591bf5a93db05R44
@HarHarLinks Thanks for the review!
Done
Sorry, I did not check the "old" arrow rotation. It should now match the "old" state.
I don't understand this. Can you elaborate, what you mean?
Can you check again?
I've updated the screen sizes to align with the mentioned changed. |
@HarHarLinks Could you take another look? |
Hi, let's do the following:
let's somehow match the arrow animation duration with the menu expansion animation, i.e. there is currently a mismatch of the submenu appearing immediately while the arrow continues to spin for 0.3s. The animation can probably also be even faster, maybe 1.5s?
Thanks! |
That's literally, what the whole PR is about. Currently it's pretty weird UX to not being able to distinguish between which menu items will show a popover on hover, and which don't. It's basically a random/surprise UX experience – which is bad. This should really be fixed. |
closes #2363
From the linked ticket it seems, that the "arrow" indicators which were appearing in the mobile version should've also been added to the desktop version. This has now been added. While I did this, I added/changed some minor things in the header:
Desktop
Before:


After:
Mobile
Before:

After:

✔️ Checklist
<>
to linkify them (learn more).[label](@/target.md)
syntax./blog
page, especially for multiple posts on the same day. Prefer UTC format, e.g.2025-12-01T14:00:00Z
for Dec 1st, 2025, 2pm UTC.