-
Notifications
You must be signed in to change notification settings - Fork 284
Optimize CLUSTER BY for statement_info and metric tables #23149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aptend
wants to merge
2
commits into
matrixorigin:main
Choose a base branch
from
aptend:mig-stat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouyuanning
approved these changes
Nov 27, 2025
zhangxu19830126
approved these changes
Nov 27, 2025
LeftHandCold
approved these changes
Nov 27, 2025
xzxiong
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize CLUSTER BY for statement_info and metric tables
What type of PR is this?
Which issue(s) this PR fixes:
Related to https://github.com/matrixorigin/MO-Cloud/issues/5327
What this PR does / why we need it:
This PR optimizes the CLUSTER BY configuration for
statement_infoandmetrictables to improve query performance and fix zonemap filtering issues.Changes
account(varchar) to(request_at, account_id)(account, metric_name, collecttime)to(collecttime, account_id, metric_name)Problem
The previous CLUSTER BY configuration used
account(varchar(1024)) as the first clustering key. This caused issues because:Solution
account(varchar) withaccount_id(int) in CLUSTER BY to avoid zonemap overflowrequest_at/collecttime) first in the clustering order to optimize time-range queriesImplementation Details
pkg/bootstrap/versions/v4_0_0/to migrate existing tablespkg/util/trace/impl/motrace/schema.goandpkg/util/metric/mometric/metric.go