fix tpp.Expects for variadic functions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Hmm I have a feeling that it's not needed any more, will try to find the example I was struggling with. If I find it, i'll write up some tests in a PR for this repo to formalise how you can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variadic functions can't really be used with
tpp.Expectsbecause of either a mismatch in number of arguments when setting up the expectations, or a mismatch in number of arguments with the actual call (e.g. in the case where no variadic args are provided)Work left to do:
Actually try to solve these cases without weakening checks on non-variadic funcitons