Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failures when writing fabric-scoped list entries (ACL and Binding) by sending a resolved fabricIndex instead of the NO_FABRIC (0) sentinel, aligning better with devices that incorrectly reject 0 during validation.
Changes:
- Add a helper to derive the peer-assigned fabric index and use it when writing AccessControl
aclentries. - Use the same resolved fabric index when writing Binding
bindingentries. - Update the changelog WORK IN PROGRESS section to note the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ws-controller/src/controller/ControllerCommandHandler.ts | Resolve and send fabricIndex for ACL and Binding attribute writes instead of NO_FABRIC (0). |
| CHANGELOG.md | Adds a WIP changelog entry for the ACL fix. |
| .get(nodeId) | ||
| .node.endpoints.for(EndpointNumber(0)) | ||
| .maybeStateOf(OperationalCredentialsClient); | ||
| return state?.currentFabricIndex ?? FabricIndex.NO_FABRIC; |
|
|
||
| ## **WORK IN PROGRESS** | ||
|
|
||
| - Fix: Fixes setting ACLs (really) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #625