Skip to content

feat: make the destination parameter of showDirections() be nullable. (NEW)#195

Open
ipcjs wants to merge 1 commit intomattermoran:masterfrom
ipcjs:feat/destination-nullable-2
Open

feat: make the destination parameter of showDirections() be nullable. (NEW)#195
ipcjs wants to merge 1 commit intomattermoran:masterfrom
ipcjs:feat/destination-nullable-2

Conversation

@ipcjs
Copy link
Copy Markdown
Contributor

@ipcjs ipcjs commented Apr 17, 2025

When it is null, use [destinationTitle] to search destination, currently only some maps support it.

[MapType.apple], supported
[MapType.google], supported
[MapType.googleGo], supported
[MapType.amap], supported
[MapType.baidu], supported
[MapType.tencent], partially supported, you need to manually click the input box to search.
others map not tested, fallback to [Coords.zero]

@ipcjs ipcjs changed the title feat: make the destination parameter of showDirections() be nullable. feat: make the destination parameter of showDirections() be nullable. (NEW) Apr 17, 2025
@ipcjs ipcjs force-pushed the feat/destination-nullable-2 branch from e156f43 to 122923b Compare April 17, 2025 06:14
@ipcjs ipcjs marked this pull request as ready for review April 17, 2025 08:11
@mattermoran
Copy link
Copy Markdown
Owner

Thanks for contribution!
Other maps will need to be checked as well otherwise it might break unexpectedly for users. I will try to get to it some time if you can't test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants