Skip to content

[MM-56555] Fix reAtMention start of number #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyberjam wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MM-56555] Fix reAtMention start of number #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c327d5
MM-56555 Fix reAtMention start of number and period, underscore, dash
cyberjam Jan 15, 2024
1fc263b
MM-56555 Add test code
cyberjam Jan 15, 2024
b2ee540
Merge branch 'master' into MM-56555_fix-reAtMention
cyberjam Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/commonmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13600,8 +13600,8 @@
};

// Attempt to parse an at mention
var reAtMention = /^@([a-z][a-z0-9._-]*)/i;
var parseAtMention = function (block) {
var reAtMention = /^@([a-z0-9._-]+)/i;
var parseAtMention = function(block) {
if (this.brackets) {
// Don't perform autolinking while inside an explicit link
return false;
Expand Down
2 changes: 1 addition & 1 deletion dist/commonmark.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/inlines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,8 +969,8 @@ var parseUrl = function (block) {
}

// Attempt to parse an at mention
var reAtMention = /^@([a-z][a-z0-9._-]*)/i;
var parseAtMention = function (block) {
var reAtMention = /^@([a-z0-9._-]+)/i;
var parseAtMention = function(block) {
if (this.brackets) {
// Don't perform autolinking while inside an explicit link
return false;
Expand Down
48 changes: 48 additions & 0 deletions test/mattermost.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,54 @@ This is an @mention123
<p>This is an <span data-mention-name="mention123" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @123mention
.
<p>This is an <span data-mention-name="123mention" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @123
.
<p>This is an <span data-mention-name="123" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @.mention
.
<p>This is an <span data-mention-name=".mention" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @.
.
<p>This is an <span data-mention-name="." /></p>
````````````````````````````````

```````````````````````````````` example
This is an @_mention
.
<p>This is an <span data-mention-name="_mention" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @_
.
<p>This is an <span data-mention-name="_" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @-mention
.
<p>This is an <span data-mention-name="-mention" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @-
.
<p>This is an <span data-mention-name="-" /></p>
````````````````````````````````

```````````````````````````````` example
This is an @mention.
.
Expand Down