Merged
Conversation
This reverts commit 4082a18.
This reverts commit 3ea1589.
Unclosed (potential) link titles containing lots of consecutive underscores caused an exponential slowdown. Thanks to Stefan Dobre for reporting.
According to the specification, blank lines in a block quote doesn't separate list items: https://spec.commonmark.org/0.30/#example-320 Therefore, the following example should be tight: - > - a > - b The specification also say that link reference definitions can be children of list items when checking list tightness: https://spec.commonmark.org/0.30/#example-317 Therefore, the following example should be loose: - [aaa]: / [bbb]: / - b This commit fixes those problems with the following strategy: - Using source end position and start position of adjoining elements to check tightness. This requires adjusting source end position of some block types to exclude trailing blank lines. - Delaying removal of link reference definitions until the entire document is parsed.
The reasoning that a failed delimiter means future delimiters will also fail only applies if the reason they failed was not the multiple-of-three rule. This was already implemented correctly for asterisks, but not for underscore.
if the info string already starts with `language-`. Closes commonmark#277.
This updates the library to conform to the 0.31 spec.
A spec 0.31 change we forgot in last release.
`trim()` as previously defined could take a long time on very long strings.
1 task
Member
Author
|
I tested this locally, and have also kicked off Detox tests via mattermost/mattermost-mobile#8722. |
Member
Author
|
@hmhealey, with mattermost/mattermost-mobile#8722 passing on this commit, what's the process after merging to publish to NPM? |
hmhealey
approved these changes
Mar 26, 2025
Member
I think I just did it manually by building the package locally, doing a dry run publish ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge @0.31.2.
Ticket Link
Relates-to: https://mattermost.atlassian.net/browse/MM-63537