Make state more flexible #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new:
- `update`
- `updateStateForKey`
- `putStateForKey`
- `getStateForKey`
refactor:
- don't make assumptions about what the state is
- this requires changes to be made to count and position itemizers,
because they had been assuming the state to be something. Now
they just assume the state has a specific key with a value of the
right type
- write `put<X>`, `get<X>` in terms of `update<X>`
- presented value of `put<X>` and `update<X>` is now the previous value,
instead of null
- pull helper functions out into separate module
lib/funcs.js
Outdated
mattfenwick
changed the title
lib/combinators.js
Outdated
There was a problem hiding this comment.
// s -> Parser e s (m t) a
var putState = F.compose(updateState, F.constF);
|
Alternate solution: think of parser in terms of a monad stack. Use one state layer for parse state, one for position counting. If the state needs to be more flexible, then just add more state layers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New combinators
updateupdateStateForKeyputStateForKeygetStateForKeyRefactoring
because they had been assuming the state to be something. Now
they just assume the state has a specific key with a value of the
right type
put<X>,get<X>in terms ofupdate<X>put<X>andupdate<X>is now the previous value,instead of null
Questions