Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import view.StepByStepView; | ||
|
|
||
| import speechapi.SystemTTS; | ||
| import data_access.SystemTTS; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Extra separation in import group before 'data_access.SystemTTS'
| import view.StepByStepView; | ||
|
|
||
| import speechapi.SystemTTS; | ||
| import data_access.SystemTTS; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'data_access.SystemTTS' import. Should be before 'view.StepByStepView'.
| import view.StepByStepView; | ||
|
|
||
| import speechapi.SystemTTS; | ||
| import data_access.SystemTTS; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> reported by reviewdog 🐶
Extra separation in import group before 'data_access.SystemTTS'
| import view.StepByStepView; | ||
|
|
||
| import speechapi.SystemTTS; | ||
| import data_access.SystemTTS; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> reported by reviewdog 🐶
Wrong order for 'data_access.SystemTTS' import.
| @@ -1,4 +1,4 @@ | |||
| package speechapi; | |||
| package data_access; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> reported by reviewdog 🐶
Name 'data_access' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.
|
|
||
| // Use system TTS | ||
| SpeechService tts = new speechapi.SystemTTS(); | ||
| SpeechService tts = new SystemTTS(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'tts' should be declared final.
hussssni
left a comment
hussssni
left a comment
There was a problem hiding this comment.
nice, watch out for checkstyle errors tho.
3 participants
refectored SystemTTS file