155 quick gui updates for meal plan generator user story#162
155 quick gui updates for meal plan generator user story#162matthew-SG merged 10 commits intomainfrom
Conversation
Currently only uses a singular strategy (only one), but it is now possible for other strategies to be easily implemented if the need arises
…style issues in the User entity.
…use-case' into 155-quick-gui-updates-for-meal-plan-generator-user-story
…din views. Also fixed some checkstyle issues.
…ved app dependency on file DAO (it can now fully function with the inmemoryDAO alone).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,23 @@ | |||
| package use_case.meal_plan; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> reported by reviewdog 🐶
Name 'use_case.meal_plan' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.
| @@ -0,0 +1,54 @@ | |||
| package use_case.meal_plan; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> reported by reviewdog 🐶
Name 'use_case.meal_plan' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.
| * DAO for all data, mainly user data, using a File to persist the data. | ||
| */ | ||
| public class FileDataAccessObject implements UserDataAccess, ApproveRecipeDataAccessInterface, CommunityUserRecipeDataAccessInterface, LikedRecipeDataAccessInterface { | ||
| public class FileDataAccessObject implements UserDataAccess { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.metrics.ClassDataAbstractionCouplingCheck> reported by reviewdog 🐶
Class Data Abstraction Coupling is 14 (max allowed is 7) classes [BufferedReader, BufferedWriter, File, FileReader, FileWriter, FindInstructionsSpoonacular, GroceryList, Ingredient, JSONArray, JSONObject, LinkedHashMap, MealPlan, Recipe, User].
| * DAO for all data, mainly user data, using a File to persist the data. | ||
| */ | ||
| public class FileDataAccessObject implements UserDataAccess, ApproveRecipeDataAccessInterface, CommunityUserRecipeDataAccessInterface, LikedRecipeDataAccessInterface { | ||
| public class FileDataAccessObject implements UserDataAccess { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.MethodCountCheck> reported by reviewdog 🐶
Total number of methods is 35 (max allowed is 34).
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> reported by reviewdog 🐶
Using the '.' form of import should be avoided - java.util..
| final LoadMealPlanController loadMealPlanController = new LoadMealPlanController(loadMealPlanInteractor); | ||
| viewMealPlansView.setLoadMealPlanController(loadMealPlanController); | ||
| DeleteMealPlanController deleteMealPlanController = new DeleteMealPlanController(deleteMealPlanInteractor); | ||
| final DeleteMealPlanController deleteMealPlanController = new DeleteMealPlanController(deleteMealPlanInteractor); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 121).
| import java.awt.event.ActionEvent; | ||
| import java.awt.event.ActionListener; | ||
|
|
||
| import javax.swing.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> reported by reviewdog 🐶
Using the '.' form of import should be avoided - javax.swing..
| import java.awt.event.ActionEvent; | ||
| import java.awt.event.ActionListener; | ||
|
|
||
| import javax.swing.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> reported by reviewdog 🐶
Using the '.' form of import should be avoided - javax.swing..
| import java.beans.PropertyChangeEvent; | ||
| import java.beans.PropertyChangeListener; | ||
|
|
||
| import javax.swing.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> reported by reviewdog 🐶
Using the '.' form of import should be avoided - javax.swing..
| import java.beans.PropertyChangeEvent; | ||
| import java.beans.PropertyChangeListener; | ||
|
|
||
| import javax.swing.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> reported by reviewdog 🐶
Using the '.' form of import should be avoided - javax.swing..
2 participants
GUI changes (mainly font or capitalization) in the meal plan generator user story, as well as the navbar and loggedin and login views. Resolved (most) checkstyle issues in modified files, and also removed the app's hard dependency on the file DAO (we should realistically be able to use any DAO now).