User management tests and javadoc by kunsileeaa · Pull Request #165 · matthew-SG/CSC207_Project

kunsileeaa · 2025-12-02T02:27:46Z

add tests for sign up, log in and log out

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Extra separation in import group before 'use_case.login.LoginInputData'

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 6 in a4ef196

import use_case.login.LoginInputData;

🚫 [checkstyle] _{reported by reviewdog 🐶}
Unnecessary consecutive lines

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 9 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Import statement for 'org.junit.jupiter.api.Assertions.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 9 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.junit.jupiter.api.Assertions.*' import.

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 9 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> _{reported by reviewdog 🐶}
Using the '.' form of import should be avoided - org.junit.jupiter.api.Assertions..

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 9 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 120 characters (found 128).

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 30 in a4ef196

    
           assertEquals(EXISTING_USERNAME, presenter.getSuccessUsername(), "Success view should be called with correct username.");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'testLoginFailure_UserDNE' must contain no more than '1' consecutive capital letters.

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 35 in a4ef196

void testLoginFailure_UserDNE() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testLoginFailure_UserDNE' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 35 in a4ef196

void testLoginFailure_UserDNE() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testLoginFailure_IncorrectPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/LoginInteractorTest.java

Line 49 in a4ef196

void testLoginFailure_IncorrectPassword() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck> _{reported by reviewdog 🐶}
File does not end with a newline.

CSC207_Project/src/test/java/use_case/user_management/MockLogoutPresenter.java

Line 1 in a4ef196

package use_case.user_management;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> _{reported by reviewdog 🐶}
Name 'use_case.user_management' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.

CSC207_Project/src/test/java/use_case/user_management/MockLogoutPresenter.java

Line 1 in a4ef196

package use_case.user_management;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> _{reported by reviewdog 🐶}
Variable 'successUsername' explicitly initialized to 'null' (default value for its type).

CSC207_Project/src/test/java/use_case/user_management/MockLogoutPresenter.java

Line 7 in a4ef196

private String successUsername = null;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck> _{reported by reviewdog 🐶}
File does not end with a newline.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 1 in a4ef196

package use_case.user_management;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> _{reported by reviewdog 🐶}
Name 'use_case.user_management' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 1 in a4ef196

package use_case.user_management;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Import statement for 'org.junit.jupiter.api.Test' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 6 in a4ef196

import org.junit.jupiter.api.Test;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.junit.jupiter.api.Test' import.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 6 in a4ef196

import org.junit.jupiter.api.Test;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Extra separation in import group before 'use_case.signup.SignupInputData'

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 7 in a4ef196

import use_case.signup.SignupInputData;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
'use_case.signup.SignupInputData' should be separated from previous imports.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 7 in a4ef196

import use_case.signup.SignupInputData;

🚫 [checkstyle] _{reported by reviewdog 🐶}
Unnecessary consecutive lines

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 10 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Import statement for 'org.junit.jupiter.api.Assertions.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 10 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.junit.jupiter.api.Assertions.*' import.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 10 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> _{reported by reviewdog 🐶}
Using the '.' form of import should be avoided - org.junit.jupiter.api.Assertions..

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 10 in a4ef196

import static org.junit.jupiter.api.Assertions.*;

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'NEW_USERNAME' must contain no more than '1' consecutive capital letters.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 15 in a4ef196

private final String NEW_USERNAME = "newUserForTest";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck> _{reported by reviewdog 🐶}
Name 'NEW_USERNAME' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 15 in a4ef196

private final String NEW_USERNAME = "newUserForTest";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'EXISTING_USERNAME' must contain no more than '1' consecutive capital letters.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 16 in a4ef196

private final String EXISTING_USERNAME = "test_1";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck> _{reported by reviewdog 🐶}
Name 'EXISTING_USERNAME' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 16 in a4ef196

private final String EXISTING_USERNAME = "test_1";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'TEST_PASSWORD' must contain no more than '1' consecutive capital letters.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 17 in a4ef196

private final String TEST_PASSWORD = "testPassword";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck> _{reported by reviewdog 🐶}
Name 'TEST_PASSWORD' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 17 in a4ef196

private final String TEST_PASSWORD = "testPassword";

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testSignupFailure_PasswordsDontMatch' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 36 in a4ef196

void testSignupFailure_PasswordsDontMatch() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testSignupFailure_EmptyPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 50 in a4ef196

void testSignupFailure_EmptyPassword() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testSignupFailure_EmptyUsername' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 64 in a4ef196

void testSignupFailure_EmptyUsername() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> _{reported by reviewdog 🐶}
Name 'testSignupFailure_UserExists' must match pattern '^[a-z][a-zA-Z0-9]*$'.

CSC207_Project/src/test/java/use_case/user_management/SignupInteractorTest.java

Line 78 in a4ef196

void testSignupFailure_UserExists() {

github-actions · 2025-12-02T02:28:11Z

+package use_case.user_management;
+
+import data_access.InMemoryUserDataAccessObject;
+import org.junit.jupiter.api.Test;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.junit.jupiter.api.Test' import.

github-actions · 2025-12-02T02:28:11Z

+
+import data_access.InMemoryUserDataAccessObject;
+import org.junit.jupiter.api.Test;
+import use_case.logout.LogoutInteractor;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
'use_case.logout.LogoutInteractor' should be separated from previous imports.

github-actions · 2025-12-02T02:28:12Z

+import org.junit.jupiter.api.Test;
+import use_case.logout.LogoutInteractor;
+
+import static org.junit.jupiter.api.Assertions.*;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> _{reported by reviewdog 🐶}
Using the '.' form of import should be avoided - org.junit.jupiter.api.Assertions..

github-actions · 2025-12-02T02:28:12Z

@@ -0,0 +1,35 @@
+package use_case.user_management;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> _{reported by reviewdog 🐶}
Name 'use_case.user_management' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.

Peter-Hu12138 · 2025-12-02T02:29:43Z

Please resolve the style problems before I merge

github-actions · 2025-12-02T02:39:25Z

@@ -0,0 +1,17 @@
+package use_case.user_management;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> _{reported by reviewdog 🐶}
Name 'use_case.user_management' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.

github-actions · 2025-12-02T02:39:26Z

+import entities.UserFactory;
+
+import org.junit.jupiter.api.Test;
+import use_case.signup.SignupInputData;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
'use_case.signup.SignupInputData' should be separated from previous imports.

github-actions · 2025-12-02T02:39:26Z

+import use_case.signup.SignupInputData;
+import use_case.signup.SignupInteractor;
+
+import static org.junit.jupiter.api.Assertions.*;


🚫 [checkstyle] _{reported by reviewdog 🐶}
Unnecessary consecutive lines

github-actions · 2025-12-02T02:39:26Z

+import use_case.signup.SignupInputData;
+import use_case.signup.SignupInteractor;
+
+import static org.junit.jupiter.api.Assertions.*;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Import statement for 'org.junit.jupiter.api.Assertions.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.

github-actions · 2025-12-02T02:39:26Z

+import use_case.signup.SignupInputData;
+import use_case.signup.SignupInteractor;
+
+import static org.junit.jupiter.api.Assertions.*;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.junit.jupiter.api.Assertions.*' import.

github-actions · 2025-12-02T02:39:26Z

+import use_case.signup.SignupInputData;
+import use_case.signup.SignupInteractor;
+
+import static org.junit.jupiter.api.Assertions.*;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck> _{reported by reviewdog 🐶}
Using the '.' form of import should be avoided - org.junit.jupiter.api.Assertions..

kunsileeaa · 2025-12-02T05:05:08Z

and add javadocs

Adish-Singh

Thank you for fixing the style of your code. The tests have 100% line coverage so great job.

kunsileeaa added 2 commits December 1, 2025 21:16

tests for login logout signup

014f172

checkstyle

a4ef196

github-actions Bot reviewed Dec 2, 2025

View reviewed changes

checkstyle

5e6a3a1

github-actions Bot reviewed Dec 2, 2025

View reviewed changes

kunsileeaa requested review from matthew-SG and removed request for matthew-SG December 2, 2025 04:03

add javadocs for all files

051e471

github-actions Bot reviewed Dec 2, 2025

View reviewed changes

kunsileeaa changed the title ~~User management tests~~ User management tests and javadoc Dec 2, 2025

Adish-Singh approved these changes Dec 2, 2025

View reviewed changes

Adish-Singh merged commit 0a2a898 into main Dec 2, 2025
1 check passed

Conversation

kunsileeaa commented Dec 2, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Peter-Hu12138 commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kunsileeaa commented Dec 2, 2025

Uh oh!

Adish-Singh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants