Conversation
…package using mystyle.xml
…e mystyle.xml file
|
Please resolve merge conflicts before I can merge |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } catch (Exception e) { | ||
| presenter.prepareFailView("Error adding recipe: " + e.getMessage()); | ||
| } | ||
| catch (Exception ex) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.IllegalCatchCheck> reported by reviewdog 🐶
Catching 'Exception' is not allowed.
| } catch (Exception e) { | ||
| presenter.prepareFailView("Error deleting recipe: " + e.getMessage()); | ||
| } | ||
| catch (Exception ex) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.IllegalCatchCheck> reported by reviewdog 🐶
Catching 'Exception' is not allowed.
| final List<String[]> ingredientsList = new ArrayList<>(); | ||
| for (Ingredient ingredient : recipe.getIngredients()) { | ||
| String[] ingredientData = new String[3]; | ||
| final String[] ingredientData = new String[3]; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MagicNumberCheck> reported by reviewdog 🐶
'3' is a magic number.
| } catch (Exception e) { | ||
| presenter.prepareFailView("Error loading recipes: " + e.getMessage()); | ||
| } | ||
| catch (Exception ex) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.IllegalCatchCheck> reported by reviewdog 🐶
Catching 'Exception' is not allowed.
| } catch (Exception e) { | ||
| presenter.prepareFailView("Error loading instructions: " + e.getMessage()); | ||
| } | ||
| catch (Exception ex) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.IllegalCatchCheck> reported by reviewdog 🐶
Catching 'Exception' is not allowed.
| } catch (Exception e) { | ||
| presenter.prepareFailView("Error adding ingredients to grocery list: " + e.getMessage()); | ||
| } | ||
| catch (Exception ex) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.IllegalCatchCheck> reported by reviewdog 🐶
Catching 'Exception' is not allowed.
matthew-SG
left a comment
matthew-SG
left a comment
There was a problem hiding this comment.
Thank you for adding comments to your code!
3 participants
No description provided.