163 implement alternative strategy in meal plan generator by matthew-SG · Pull Request #169 · matthew-SG/CSC207_Project

matthew-SG · 2025-12-02T02:57:17Z

Implemented an alternative strategy for meal plan generator

… interactor. Now will have to give the user such option in the view.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 115 in ba327ae

    
           InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'mealPlanInputData' declaration and its first usage is 18, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 159 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("1", "1", "1", "1", "default");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'mealPlanInputData' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 159 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("1", "1", "1", "1", "default");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 161 in ba327ae

    
           InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'mealPlanInputData' declaration and its first usage is 31, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 233 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("50", "50", "50", "50", "default");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'mealPlanInputData' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 233 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("50", "50", "50", "50", "default");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 235 in ba327ae

    
           InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.metrics.JavaNCSSCheck> _{reported by reviewdog 🐶}
NCSS for this method is 58 (max allowed is 50).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 327 in ba327ae

@Test

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.ExecutableStatementCountCheck> _{reported by reviewdog 🐶}
Executable statement count is 50 (max allowed is 30).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 327 in ba327ae

@Test

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'mealPlanInputData' declaration and its first usage is 31, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 331 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("50", "50", "50", "50", "calories");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'mealPlanInputData' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 331 in ba327ae

    
           MealPlanInputData mealPlanInputData = new MealPlanInputData("50", "50", "50", "50", "calories");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 333 in ba327ae

    
           InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'ingredients' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 340 in ba327ae

List<Ingredient> ingredients = new ArrayList<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'nutritionalInfo1' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 344 in ba327ae

Map<String, Double> nutritionalInfo1 = new HashMap<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'nutritionalInfo2' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 350 in ba327ae

Map<String, Double> nutritionalInfo2 = new HashMap<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'nutritionalInfo3' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 356 in ba327ae

Map<String, Double> nutritionalInfo3 = new HashMap<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'nutritionalInfo4' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 362 in ba327ae

Map<String, Double> nutritionalInfo4 = new HashMap<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'recipe1' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 369 in ba327ae

Recipe recipe1 = new Recipe(1234, "spaghetti", "idontexist.jpg", ingredients,

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'recipe2' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 371 in ba327ae

Recipe recipe2 = new Recipe(1324, "linguini", "idontexist.jpg", ingredients,

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'recipe3' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 373 in ba327ae

Recipe recipe3 = new Recipe(3124, "fettuccine", "idontexist.jpg", ingredients,

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'recipe4' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 375 in ba327ae

Recipe recipe4 = new Recipe(5678, "tortellini", "iDOexist.jpg", ingredients,

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'likedRecipes' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 378 in ba327ae

List<Recipe> likedRecipes = userRepository.getSavedRecipes();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'expectedNames' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 386 in ba327ae

String[] expectedNames = {"spaghetti", "linguini", "fettuccine"};

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'expectedNames' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 386 in ba327ae

String[] expectedNames = {"spaghetti", "linguini", "fettuccine"};

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'expectedImages' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 387 in ba327ae

    
           String[] expectedImages = {"idontexist.jpg", "idontexist.jpg", "idontexist.jpg"};

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'expectedImages' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 387 in ba327ae

    
           String[] expectedImages = {"idontexist.jpg", "idontexist.jpg", "idontexist.jpg"};

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'expectedIngredients' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 389 in ba327ae

List<List<String[]>> expectedIngredients = new ArrayList<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'nestedIngredients' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 390 in ba327ae

List<String[]> nestedIngredients = new ArrayList<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> _{reported by reviewdog 🐶}
',' is not followed by whitespace.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 394 in ba327ae

nestedIngredients.add(new String[]{"salt","100.0","kg"});

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> _{reported by reviewdog 🐶}
',' is not followed by whitespace.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 394 in ba327ae

nestedIngredients.add(new String[]{"salt","100.0","kg"});

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'expectedNutritionalInfo' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 396 in ba327ae

List<Map<String, Double>> expectedNutritionalInfo = new ArrayList<>();

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'presenter' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 405 in ba327ae

MealPlanOutputBoundary presenter = new MealPlanOutputBoundary() {

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'interactor' should be declared final.

CSC207_Project/src/test/java/use_case/meal_plan/MealPlanInteractorTests.java

Line 420 in ba327ae

    
           MealPlanInputBoundary interactor = new MealPlanInteractor(userRepository, presenter);

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> _{reported by reviewdog 🐶}
Name 'use_case.meal_plan' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.

CSC207_Project/src/main/java/use_case/meal_plan/PrioritizeCaloriesErrorStrategy.java

Line 1 in ba327ae

package use_case.meal_plan;

github-actions · 2025-12-02T03:00:59Z

-        // Create DAO and user for the purposes of the test
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        // Create DAO and user for the purposes of the test, api key doesn't matter
+        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

github-actions · 2025-12-02T03:00:59Z

+        // Temp DAO for testing, api key doesn't matter
        FakeRecipeDAO fakeDAO = new FakeRecipeDAO();
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

github-actions · 2025-12-02T03:01:00Z

        FakeRecipeDAO fakeDAO = new FakeRecipeDAO();
        fakeDAO.recipesToReturn = new ArrayList<>();
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

github-actions · 2025-12-02T03:01:00Z

        FakeRecipeDAO fakeDAO = new FakeRecipeDAO();
        fakeDAO.exceptionToThrow = new RuntimeException("Simulated API failure");
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("a");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

github-actions · 2025-12-02T03:01:00Z

        FakeRecipeDAO fakeDAO = new FakeRecipeDAO();
        fakeDAO.recipesToReturn = null;  // ← key difference
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject("");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'userRepository' should be declared final.

github-actions · 2025-12-02T03:01:02Z

-        MealPlanInputData inputData4 = new MealPlanInputData("1", "2", "3", "-1");
-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        MealPlanInputData inputData1 = new MealPlanInputData("-1", "1", "2", "3", "default");
+        MealPlanInputData inputData2 = new MealPlanInputData("1", "-1", "2", "3", "default");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'inputData2' should be declared final.

github-actions · 2025-12-02T03:01:02Z

-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        MealPlanInputData inputData1 = new MealPlanInputData("-1", "1", "2", "3", "default");
+        MealPlanInputData inputData2 = new MealPlanInputData("1", "-1", "2", "3", "default");
+        MealPlanInputData inputData3 = new MealPlanInputData("1", "2", "-1", "3", "default");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'inputData3' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

github-actions · 2025-12-02T03:01:02Z

-        InMemoryUserDataAccessObject userRepository = new InMemoryUserDataAccessObject();
+        MealPlanInputData inputData1 = new MealPlanInputData("-1", "1", "2", "3", "default");
+        MealPlanInputData inputData2 = new MealPlanInputData("1", "-1", "2", "3", "default");
+        MealPlanInputData inputData3 = new MealPlanInputData("1", "2", "-1", "3", "default");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'inputData3' should be declared final.

github-actions · 2025-12-02T03:01:02Z

+        MealPlanInputData inputData1 = new MealPlanInputData("-1", "1", "2", "3", "default");
+        MealPlanInputData inputData2 = new MealPlanInputData("1", "-1", "2", "3", "default");
+        MealPlanInputData inputData3 = new MealPlanInputData("1", "2", "-1", "3", "default");
+        MealPlanInputData inputData4 = new MealPlanInputData("1", "2", "3", "-1", "default");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'inputData4' declaration and its first usage is 9, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

github-actions · 2025-12-02T03:01:02Z

+        MealPlanInputData inputData1 = new MealPlanInputData("-1", "1", "2", "3", "default");
+        MealPlanInputData inputData2 = new MealPlanInputData("1", "-1", "2", "3", "default");
+        MealPlanInputData inputData3 = new MealPlanInputData("1", "2", "-1", "3", "default");
+        MealPlanInputData inputData4 = new MealPlanInputData("1", "2", "3", "-1", "default");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'inputData4' should be declared final.

Adish-Singh

good

matthew-SG added 3 commits December 1, 2025 21:12

Fixed issues with constructor calls on the InMemory DAO

f664c84

Implemented the option of another strategy in the meal plan generator…

0967fe1

… interactor. Now will have to give the user such option in the view.

Implemented capabilities to switch meal plans in the view

ba327ae

matthew-SG linked an issue Dec 2, 2025 that may be closed by this pull request

Implement alternative strategy in meal plan generator. #163

Closed

github-actions Bot reviewed Dec 2, 2025

View reviewed changes

Adish-Singh approved these changes Dec 2, 2025

View reviewed changes

Adish-Singh merged commit 2ae7038 into main Dec 2, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

163 implement alternative strategy in meal plan generator#169

163 implement alternative strategy in meal plan generator#169
Adish-Singh merged 3 commits intomainfrom
163-implement-alternative-strategy-in-meal-plan-generator

matthew-SG commented Dec 2, 2025

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

github-actions Bot Dec 2, 2025

Uh oh!

Adish-Singh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

matthew-SG commented Dec 2, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Adish-Singh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants