Conversation
added tests to liked recipe list
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'lastSavedRecipe' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'liked' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.LambdaParameterNameCheck> reported by reviewdog 🐶
Name 'u' must match pattern '^(id)|([a-z][a-z0-9][a-zA-Z0-9]+)$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'liked' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.LambdaParameterNameCheck> reported by reviewdog 🐶
Name 'r' must match pattern '^(id)|([a-z][a-z0-9][a-zA-Z0-9]+)$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck> reported by reviewdog 🐶
Return count is 3 (max allowed for non-void methods/lambdas is 1).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'liked' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'u' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck> reported by reviewdog 🐶
Class FakePresenter should be declared as final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'lastOutput' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'lastHandsfreeInput' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'lastError' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> reported by reviewdog 🐶
Variable 'likedViewCalls' explicitly initialized to '0' (default value for its type).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'likedViewCalls' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> reported by reviewdog 🐶
Variable 'handsfreeCalls' explicitly initialized to '0' (default value for its type).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'handsfreeCalls' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> reported by reviewdog 🐶
Variable 'failCalls' explicitly initialized to '0' (default value for its type).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'failCalls' must be private and have accessor methods.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'nutr' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_successNewRecipe' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipe' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_recipeNotFound' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_userNotFound' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipe' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_alreadySaved' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipe' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_exceptionHandled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'deleteLikedRecipe_success' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'r1' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'r2' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'deleteLikedRecipe_userNotFound' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'deleteLikedRecipe_exceptionHandled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'loadLikedRecipes_populatesOutput' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'dao' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'ingredients' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'r1' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'out' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'ingStrings' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'loadLikedRecipes_exceptionHandled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'handsfree_success' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'result' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'instructions' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'handsfree_exceptionHandled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'result' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_recipeNotFound' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_noIngredients' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipe' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_success' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'dao' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'ing' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipe' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_exceptionHandled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addLikedRecipe_alreadyHasDifferentRecipeId' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'existing' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'newOne' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_nonMatchingRecipeIdInList' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'ing' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'r' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck> reported by reviewdog 🐶
Don't use trailing comments.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck> reported by reviewdog 🐶
Init blocks, constructors, fields and methods should be before inner types.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'addIngredientsToGrocery_ingredientsNull' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'dao' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'presenter' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'presenter' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'user' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'nutr' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'recipeWithNullIngredients' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> reported by reviewdog 🐶
Variable 'interactor' should be declared final.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.
| @@ -0,0 +1,596 @@ | |||
| package use_case.liked_recipe_list; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck> reported by reviewdog 🐶
Name 'use_case.liked_recipe_list' must match pattern '^[a-z]+(.[a-zA-Z_]\w*)*$'.
| import entities.Recipe; | ||
| import entities.RecipeInstructions; | ||
| import entities.User; | ||
| import org.junit.Test; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Import statement for 'org.junit.Test' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.
| import entities.Recipe; | ||
| import entities.RecipeInstructions; | ||
| import entities.User; | ||
| import org.junit.Test; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> reported by reviewdog 🐶
Wrong order for 'org.junit.Test' import.
| import entities.RecipeInstructions; | ||
| import entities.User; | ||
| import org.junit.Test; | ||
| import use_case.step_by_step.StepByStepInputData; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> reported by reviewdog 🐶
'use_case.step_by_step.StepByStepInputData' should be separated from previous imports.
| import org.junit.Test; | ||
| import use_case.step_by_step.StepByStepInputData; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Import statement for 'java.util.*' is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group, expecting not assigned imports on this line.
| // Flags to force exceptions | ||
| boolean throwOnGetCurrentUsername = false; | ||
| boolean throwOnGetLikedRecipes = false; | ||
| boolean throwOnGetAnalyzedInstructions = false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> reported by reviewdog 🐶
Variable 'throwOnGetAnalyzedInstructions' explicitly initialized to 'false' (default value for its type).
| // Flags to force exceptions | ||
| boolean throwOnGetCurrentUsername = false; | ||
| boolean throwOnGetLikedRecipes = false; | ||
| boolean throwOnGetAnalyzedInstructions = false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'throwOnGetAnalyzedInstructions' must be private and have accessor methods.
| boolean throwOnGetCurrentUsername = false; | ||
| boolean throwOnGetLikedRecipes = false; | ||
| boolean throwOnGetAnalyzedInstructions = false; | ||
| boolean throwOnGetLikedRecipesInGrocery = false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.ExplicitInitializationCheck> reported by reviewdog 🐶
Variable 'throwOnGetLikedRecipesInGrocery' explicitly initialized to 'false' (default value for its type).
| boolean throwOnGetCurrentUsername = false; | ||
| boolean throwOnGetLikedRecipes = false; | ||
| boolean throwOnGetAnalyzedInstructions = false; | ||
| boolean throwOnGetLikedRecipesInGrocery = false; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'throwOnGetLikedRecipesInGrocery' must be private and have accessor methods.
| boolean throwOnGetLikedRecipesInGrocery = false; | ||
|
|
||
| // For addLikedRecipe save tracking | ||
| String lastSavedUsername; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'lastSavedUsername' must be private and have accessor methods.
Adish-Singh
left a comment
There was a problem hiding this comment.
Thank you for adding the comments. The tests have 100% line coverage so great job.
added comments to search by ing files
added tests to liked recipe list