main: add go-version compatibility.#222
Open
ziggie1984 wants to merge 1 commit intomattn:masterfrom
Open
Conversation
When a project uses gomodules which are versioned it can happen that the source file of the module is not directly under the module name but instead the versioning happened via a branch so that the file will be found without the particular version string as a subdirectory. So this commit will retry to find the particular file in the main directory instead of the version subdirectory.
ziggie1984
added a commit
to ziggie1984/lnd
that referenced
this pull request
Dec 12, 2024
The goverall tool had a bug regarding the module versioning of golang packages see also mattn/goveralls#222 for more background. Goveralls is wrapped by another library to make it available for github actions. So the relevant PR which is referenced here in LND is: shogo82148/actions-goveralls#521.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project uses gomodules which are versioned it can happen
that the source file of the module is not directly under the
module name but instead the versioning happened via a branch so
that the file will be found without the particular version string
as a subdirectory. So this commit will retry to find the particular
file in the main directory instead of the version subdirectory.