WIP: Update get_references function to use bibTeX references from webpage#151
Open
mattpitkin wants to merge 4 commits intomainfrom
Open
WIP: Update get_references function to use bibTeX references from webpage#151mattpitkin wants to merge 4 commits intomainfrom
mattpitkin wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
get_referencesfunction use the information in theparcat_reffile within the downloadable catalogue tarball. However, this does not appear to contain all the most up-to-date references (see #150), whereas these are on the references webpage. This PR will attempt to rewriteget_referencesto use the information directly from the webpage, which are given in a convenient bibTeX format. These often also contain the ADS URL already, which means they will not have to be generated in many cases. I'll probably need to use beautifulsoup and something like bibtexparser for this.