Added support for HTTPS and custom port on attach.#41
Open
StepanZharychev wants to merge 1 commit intomattstyles:masterfrom
StepanZharychev:master
Open
Added support for HTTPS and custom port on attach.#41StepanZharychev wants to merge 1 commit intomattstyles:masterfrom StepanZharychev:master
StepanZharychev wants to merge 1 commit intomattstyles:masterfrom
StepanZharychev:master
Conversation
Author
|
Please, notice, that Travis that you use is not familiar with rest operator of JS(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters) and fails on it. While node's supported all ES6 feature for a long time. Seems that you need to update this tester somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was mentioned in one of issues there's no support for HTTPS connection in created socket. I added configuration object for attach method that can accept paths to cert and key, which are required for HTTPS connection. Plus I added ability to specify custom port for socket which can be useful as well to my mind. Please, take a look.