Replace OnSceneWasLoaded with sceneLoaded delegate #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysp
changed the title
mattvr
requested changes
Feb 4, 2018
Owner
mattvr
left a comment
mattvr
left a comment
There was a problem hiding this comment.
SceneManager.sceneLoaded should be unsubscribed from when the script is destroyed (ie OnDestroy()).
This will also require you using a named method instead of an anonymous method.
Owner
|
Thanks for the contribution @rhysp! I've stopped working on it myself but will approve pull requests if they're tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3
Unfortunately I'm unsure how to open the standalone
Scene.unityfile (to recompileSyrinj.unitypackageand also ensure tests are still passing. Happy to review with any insight.