Closed
Conversation
Collaborator
Author
|
Passed! - Failed: 0, Passed: 79, Skipped: 0, Total: 79, Duration: 2 s - Mvkt.Api.Tests.dll (net7.0) @TristanAllaire |
Collaborator
Author
{
"summary": {
"isDelegating": true,
"delegatedValidator": {
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
"delegatedBalance": 1692176031042,
"delegationTime": "2026-01-08T12:59:49Z",
"isStaking": true,
"stakedValidators": [
{
"baker": {
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
"stakedBalance": 1681000000000
}
],
"totalStakedBalance": 1681000000000,
"totalRewardsEarned": 11348190541,
"rewardsByValidator": [
{
"validator": {
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
"totalRewards": 11348190541,
"cycleCount": 14,
"firstCycle": 45,
"lastCycle": 58,
"totalStakingRewards": 9654903735,
"totalDelegationRewards": 1693286806,
"isCurrentValidator": true
}
],
"rewardsByCycle": [
{
"cycle": 58,
"rewards": 0,
"delegatedBalance": 873884116,
"stakedBalance": 1690673978101,
"validator": {
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
"stakingRewards": 0,
"delegationRewards": 0
},
...
{
"cycle": 45,
"rewards": 728742898,
"delegatedBalance": 392200107338,
"stakedBalance": 800335382962,
"validator": {
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
"stakingRewards": 627916741,
"delegationRewards": 100826157
}
],
"stakingPercentage": 99.3395467825461,
"delegationPercentage": 100,
"totalValidatorsUsed": 1,
"currentValidatorCount": 1,
"pastValidatorCount": 0,
"firstRewardCycle": 45,
"lastRewardCycle": 58,
"totalCyclesWithRewards": 14
},
"actualRewards": {
"totalActualRewards": 11348190541,
"delegationPayouts": 1693286806,
"delegationPayoutCount": 11,
"stakingRewardsRestaked": 9654903735,
"stakingRestakeCount": 12,
"expectedDelegationRewards": 1187963556,
"expectedStakingRewards": 9654903735,
"expectedTotalRewards": 10842867291,
"pendingDelegation": 0,
"pendingStaking": 0,
"pendingTotal": 0,
"byValidator": [
{
"address": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ",
"expectedStakingRewards": 9654903735,
"expectedDelegationRewards": 1187963556,
"expectedTotalGross": 10842867291,
"actualDelegationPayouts": 1693286806,
"actualStakingRestaked": 9654903735,
"actualTotalReceived": 11348190541,
"pendingDelegation": 0,
"pendingStaking": 0,
"pendingTotal": 0,
"paymentStatus": "fully_paid",
"paymentPercentage": 100,
"cycleCount": 14,
"firstCycle": 45,
"lastCycle": 58,
"stakingRewardsByCycle": [
{
"cycle": 56,
"amount": 564158207
},
...
{
"cycle": 45,
"amount": 627916741
}
],
"stakingRestakeEventCount": 12,
"delegationByCycle": [
{
"cycle": 56,
"expectedReward": 1794137,
"status": "overpaid",
"validatorAddress": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
....
{
"cycle": 45,
"expectedReward": 100826157,
"status": "paid",
"validatorAddress": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
}
]
}
],
"allStakingRewardEvents": [
{
"cycle": 56,
"amount": 564158207,
"validatorAddress": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
},
...
{
"cycle": 45,
"amount": 627916741,
"validatorAddress": "mv1MtuibrK2PZpbJLhe1zkxfLq9HXwRsFWuZ"
}
],
"firstRewardDate": "2026-01-18T14:28:54Z",
"lastRewardDate": "2026-02-16T01:25:04Z"
},
"estimatedNextPayout": "2026-02-17T08:27:37.1818181Z",
"avgPayoutIntervalDays": 1.2934396043771
} |
| /// <summary> | ||
| /// Summary of rewards for a specific cycle | ||
| /// </summary> | ||
| public class CycleRewardSummary |
Collaborator
Author
There was a problem hiding this comment.
Hm, they are not duplicates, because DelegatorRewards is the input model the service uses, and CycleRewardSummary is the output DTO that is derived from DelegatorRewards and returned to the client. It contains aggregated data from DelegatorRewards
new CycleRewardSummary
{
Cycle = r.Cycle,
Rewards = stakingReward + delegationReward,
DelegatedBalance = r.DelegatedBalance,
StakedBalance = r.StakedBalance,
Validator = new Alias { Address = r.Baker?.Address, Name = r.Baker?.Name },
StakingRewards = stakingReward,
DelegationRewards = delegationReward
};
Deploying mvkt-atlasnet with
|
| Latest commit: |
3f13123
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4abdb95b.mvkt-atlasnet.pages.dev |
| Branch Preview URL: | https://feature-delegation-info.mvkt-atlasnet.pages.dev |
Deploying mvkt-mainnet with
|
| Latest commit: |
3f13123
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e52d375.mvkt.pages.dev |
| Branch Preview URL: | https://feature-delegation-info.mvkt.pages.dev |
Deploying mvkt-basenet with
|
| Latest commit: |
3f13123
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdc19b90.mvkt-basenet.pages.dev |
| Branch Preview URL: | https://feature-delegation-info.mvkt-basenet.pages.dev |
|
| /// <summary> | ||
| /// Validator address | ||
| /// </summary> | ||
| public string Address { get; set; } |
There was a problem hiding this comment.
Could the Alias table be used there?
| "AllowedHosts": "*" | ||
| "AllowedHosts": "*", | ||
| "Delegation": { | ||
| "ValidatorPayoutAddresses": { |
There was a problem hiding this comment.
Please explain this. Listing all validator payment addresses by hand per mvkt instance is something no one will do + payment addresses are dynamic
| /// <summary> | ||
| /// Validator address | ||
| /// </summary> | ||
| public string ValidatorAddress { get; set; } |
There was a problem hiding this comment.
Could the Alias table be used there?
| /// <summary> | ||
| /// Baker (validator) address | ||
| /// </summary> | ||
| public string BakerAddress { get; set; } |
There was a problem hiding this comment.
Could the Alias table be used there?
Collaborator
Author
|
This logic will be moved to the mvkt-bff service. @TristanAllaire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was implemented
GET /v1/rewards/delegators/{address}/summaryreturning delegation and staking summary for an account (delegator or contract).legacy(defaulttrue) for account resolution (deprecation/migration).Response body
summary- Delegation and staking status: delegate, balances, staking per validators, rewards by validator and by cycle (cycles newest-first), cycle and validator counts.actualRewards- Actual rewards: delegation payouts, staking restakes, expected/pending amounts, per-validator breakdown with payment status (fully_paid,pending,underpaid,overpaid), list of staking reward events.estimatedNextPayout,avgPayoutIntervalDays,lastVote- Estimated next payout, average payout interval, last vote.Implementation
DelegationSummaryServiceaggregates data fromAccountRepository,RewardsRepository,StakingRepository,OperationRepository(including delegation payouts and optional payouts from configured validator payout addresses).DelegationConfig(sectionDelegationin appsettings):ValidatorPayoutAddresses- validator → alternative payout addresses; payouts from these addresses are counted as that validator’s payouts.legacy.Mvkt.Api/Models/DelegationInfo/:DelegationInfo,DelegationSummary,ActualRewards, and related DTOs.Tests
TestDelegationSummaryQueries: full response structure, non-existent address (200 + empty summary),legacy=true/false, contract (originator),rewardsByCycleorder (desc), structure ofallStakingRewardEventsandbyValidator, allowed payment status values.