forked from baking-bad/tzkt
-
Notifications
You must be signed in to change notification settings - Fork 1
Implemented cycle reward summaries to home #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
857e454
Implemented cycle reward summaries to home
0xVoronov 4315e3a
Updated settings
0xVoronov 9aa6a5e
Updated total cycles in home page
0xVoronov 2e8f17c
Updated settings
0xVoronov 22feec0
Removed cycles count
0xVoronov 0e124f9
Updated settings
0xVoronov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| namespace Mvkt.Api.Models | ||
| { | ||
| public class NetworkRewardsData | ||
| { | ||
| public long TotalRewardsAllTime { get; set; } | ||
| public long TotalBlockRewards { get; set; } | ||
| public long TotalEndorsementRewards { get; set; } | ||
| public long TotalBlockFees { get; set; } | ||
| public double AverageRewardsPerCycle { get; set; } | ||
| public List<CycleRewardSummary> CycleRewardSummaries { get; set; } = new(); | ||
| } | ||
|
|
||
| public class CycleRewardSummary | ||
| { | ||
| public int Cycle { get; set; } | ||
| public long TotalBlockRewards { get; set; } | ||
| public long TotalEndorsementRewards { get; set; } | ||
| public long TotalBlockFees { get; set; } | ||
| public long TotalRewards { get; set; } | ||
| public int ActiveBakers { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a heavy computation that wouldn't scale with the growing amount of bakers. Did you stress test /home before and after the addition? It may cause a spike in cpu/mem so I want to be sure that it's harmless
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several points:
/homerequest; it runs only duringUpdateAsync()updates, once perUpdatePeriodlevels. Therefore, I don’t see any issues with this query, as it places only a moderate load on the database.I ran a quick test of the query itself using
EXPLAIN, and also tested the method in a loop. We’ll need to set up an environment to perform proper load testing in a cluster on a real machine, but that can be done later.BakerCycles GROUP BY Cycle (cycle reward summaries)
Runs: 5000
Min: 0.8 ms
Max: 6.1 ms
Avg: 1.0 ms
Median: 0.9 ms
p95: 1.5 ms
p99: 2.3 ms