Conversation
Author
|
hold on - I just noticed moving all shortcakes to async does not seem to work in some cases. I'm not sure how to reproduce it (yet) but it appears that using the icon shortcode in nested njk templates leads to an error |
Owner
|
this is a good addition, thank you! regarding the async issue, I would opt to register just the image shortcode as async and leave the icon shortcode as-is, since it doesn't return a promise. may have to rethink that "register all shortcodes in a loop" approach in the eleventy.js config though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i noticed package.json lists "@11ty/eleventy-img": "^0.8.2" as a dependancy.
I've added the shortcode as per eleventy docs.
I've also modified the the shortcodes to be asnyc