Updating Readme when sprockets-rails v.2.1.0 or lower #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trying this gem and following the github readme, I noticed that the gem isn't referencing "Jcrop.gif". Unless I'm missing something, this file (and so the minify mersion) needs this line.
Removed depend_onasset for Jcrop.gif
Updating Readme to tell users they might need to add //= depend_on_asset "Jcrop.gif" if they are on a older version of sprockets-rails gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating readme to let gem users know that they might need to add
//= depend_on_asset "Jcrop.gif"on css file if they are running and older version of the sprockets-rails gem