Do not pass the entire configuration to specific classes#12
Merged
lauraengelhardt merged 7 commits intomainfrom Aug 4, 2025
Merged
Do not pass the entire configuration to specific classes#12lauraengelhardt merged 7 commits intomainfrom
lauraengelhardt merged 7 commits intomainfrom
Conversation
and not the entire config
maxiludwig
reviewed
Aug 4, 2025
lauraengelhardt
force-pushed
the
restructuring-cleanup
branch
from
0983707 to
6d7cddb
Compare
maxiludwig
approved these changes
Aug 4, 2025
Collaborator
Author
|
I included your changes, PR is ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second big batch of clean up. The main change is that we no not want to pass the entire configuration data to all substeps. At this state the run function looks really messy but this is changed in the subsequent PRs.