Merged
Conversation
lauraengelhardt
force-pushed
the
implement_config_validator
branch
from
f19ee5e to
a94322d
Compare
maxiludwig
previously approved these changes
Aug 5, 2025
Owner
maxiludwig
left a comment
maxiludwig
left a comment
There was a problem hiding this comment.
Thanks a lot. I like the new input structure and that its validated right away. 🥇
lauraengelhardt
force-pushed
the
implement_config_validator
branch
2 times, most recently
from
0e20beb to
11ceb3d
Compare
executed with pytest
lauraengelhardt
force-pushed
the
implement_config_validator
branch
from
11ceb3d to
649f17f
Compare
Collaborator
Author
|
Great, thanks for the review! |
maxiludwig
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I implemented a validator that takes the configuration file, validates the input and returns the validated I2PPConfig object containing the data in the appropriate formats.