Skip to content

[test] Add failing test for null masked_bank_account_number (PLS-1746)#105

Merged
imlukedewitt merged 1 commit intomainfrom
PLS-1746-failing-test
May 8, 2026
Merged

[test] Add failing test for null masked_bank_account_number (PLS-1746)#105
imlukedewitt merged 1 commit intomainfrom
PLS-1746-failing-test

Conversation

@imlukedewitt
Copy link
Copy Markdown
Contributor

@imlukedewitt imlukedewitt commented May 6, 2026

Ticket: https://maxioevolution.atlassian.net/browse/PLS-1746

Summary:

Adds a failing e2e test that proves the SDK throws a schema validation error when masked_bank_account_number is null in the API response. This happens when a payment profile is created via vault token (no real bank account number).

What the new test does:

  • Creates a subscription with a vault-token-based bank account payment profile (AllVaults.Bogus + vaultToken)
  • Calls listSubscriptions
  • SDK throws: Expected value to be of type 'string' but found 'object'. Given value: null. Path: payment_profile › masked_bank_account_number

Next steps:

  1. Fix masked_bank_account_number nullability in the OpenAPI spec (developer-portal)
  2. Regenerate SDK
  3. Verify this test passes

When a payment profile is created via vault token, the API returns
masked_bank_account_number: null. The SDK schema validator rejects this
because it expects a non-nullable string, causing listSubscriptions to throw.
@imlukedewitt imlukedewitt force-pushed the PLS-1746-failing-test branch from 6e6fdfa to 289d398 Compare May 6, 2026 16:54
@imlukedewitt imlukedewitt changed the title Add failing test for null masked_bank_account_number (PLS-1746) [test] Add failing test for null masked_bank_account_number (PLS-1746) May 6, 2026
@imlukedewitt imlukedewitt marked this pull request as ready for review May 6, 2026 17:20
@imlukedewitt imlukedewitt merged commit 4aecf7e into main May 8, 2026
1 check failed
@imlukedewitt imlukedewitt deleted the PLS-1746-failing-test branch May 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants