Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces allocations/copies during COSE Sig_structure (TBS) construction by switching from owned CborValue building to a borrowed-slice CBOR serialization path, while keeping the crate’s externally re-exported API unchanged.
Changes:
- Fixes an error message typo in
sign_with_ctx. - Introduces
CborSlice+serialize_arrayfor CBOR array serialization from borrowed data. - Updates COSE
sig_structureconstruction to serialize directly fromphdr/payloadslices to avoid intermediateVec<u8>copies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/sign.rs |
Improves the signature-size error message text. |
src/cose.rs |
Uses borrowed-slice CBOR array serialization for TBS construction to avoid copying phdr/payload. |
src/cbor.rs |
Adds a small borrowed CBOR representation (CborSlice) and a helper to serialize an array without intermediate copies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5a5ae0e to
5d58dc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CborValueis convenient for handling ownedvecs, but results in extra-copy for TBS construction.This PR avoids that extra copy, and does not change the lib interface.
This also pins dependencies via commit hashes rather than tags for better reproducibility prospective.