Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves diagnostics by propagating human-readable OpenSSL error-queue details through signing, verification, and key (de)serialization paths, and updates/adds tests to assert on those error strings.
Changes:
- Add
ossl_err_string()helper and include OpenSSL error details in manyErr(String)returns across wrappers/sign/verify. - Update COSE, sign, verify, and key import tests to assert on specific propagated error messages/details.
- Refine error messages to include the OpenSSL function name and return code.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/verify.rs |
Adds OpenSSL error-queue detail to verify failures and introduces verify behavior tests. |
src/sign.rs |
Adds OpenSSL error-queue detail to signing failures and introduces sign behavior tests. |
src/ossl_wrappers.rs |
Introduces ossl_err_string() and threads OpenSSL error detail through key/context/ecdsa conversion errors; expands tests. |
src/cose.rs |
Tightens negative tests to assert exact error strings and adds error-propagation tests through COSE APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cc42686 to
8b025e4
Compare
8b025e4 to
22ef455
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.