Updated MainActivity.java and menu_main.xml#27
Open
cmeher196 wants to merge 4 commits intomayank-kgp:masterfrom
Open
Updated MainActivity.java and menu_main.xml#27cmeher196 wants to merge 4 commits intomayank-kgp:masterfrom
cmeher196 wants to merge 4 commits intomayank-kgp:masterfrom
Conversation
added 4 commits
December 1, 2017 02:07
commented the code from line 227 to 246 which need to be remove completely because we want remove menu from our page or activity. Also need to remove the menu.xml file from res folder as no more connection setup in the activity.
commented the xml code which no more excutable
deleted the code for menu option....
deleted the menu_main.xml file to remove the xml file made for menu option in the activity.
Owner
|
@cmeher196 Please squash the commits. |
Author
|
sry to say but i m unble to squash the commits..... |
Author
|
@mayank-kgp did u go check the commits??? is the work done?? or i need to modify more??? |
Owner
|
@cmeher196 Commit looks fine. But you need to squash them. |
Owner
|
@cmeher196 Tell me how did you try to squash them. What did you search on Google? Which link did you follow? |
Author
|
actually i dont use git through terminal and i m totally new to this,
so i used through web github and made the changes as commit bt unable to
squash them altogather
I m using windows and not linux.
So kindly help me out.
Thank you
…On Mon, Dec 4, 2017 at 6:22 PM, MAYANK JINDAL ***@***.***> wrote:
@cmeher196 <https://github.com/cmeher196> Tell me how did you try to
squash them. What did you search on Google? Which link did you follow?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVgWHe6f_bbCzAE83yPN64cGFYbmHpGIks5s8-rugaJpZM4QxLTZ>
.
|
Owner
|
@cmeher196 For git purpose, please use the terminal which is present in the android studio. |
Owner
|
@cmeher196 Can you please check this one - http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html |
Author
|
Sry to infrm tht due some prblm i m unable to squash....
Bt still then can u merge the PRs???
…On 6 Dec 2017 11:24 pm, "MAYANK JINDAL" ***@***.***> wrote:
@cmeher196 <https://github.com/cmeher196> Can you please check this one -
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVgWHVz1cZXwIhcnxuBb2ModgCvP71eSks5s9tTYgaJpZM4QxLTZ>
.
|
Owner
|
@cmeher196 At least, follow the 2nd point of this discussion - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the menu_main.xml file from res folder and deleted the lines of codes for optionmenu...in MainActivity.java
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.