Three different issues fixed -splash screen,settings button,clear button issue#40
Three different issues fixed -splash screen,settings button,clear button issue#40ishudohare wants to merge 3 commits intomayank-kgp:masterfrom ishudohare:master
Conversation
Hi,this is Ishu Dohare,junior undergrad at IIT BHU. I have solved the splash screen issue,.
the settings button issue is fixed.
the clear button issue is fixed plus I have added another function which clears all the text along with a Toast showing that the text has been cleared.
|
Please send separate PR for the different issues. |
|
I have fixed three different issues in one pull request.
Is it necessary to send 3 different pull request for each issue?
…On Dec 15, 2017 1:46 PM, "MAYANK JINDAL" ***@***.***> wrote:
Please send separate PR for the different issues.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQgxT731U-GRnsdVIVGzvNBqZjcieGcRks5tAirDgaJpZM4RDJUG>
.
|
|
Yes. It is necessary. |
| findViewById(R.id.btnClear).setOnClickListener(new View.OnClickListener() { | ||
| @Override | ||
| public void onClick(View v) { | ||
| txtScreen.setText(""); // Clear the screen |
There was a problem hiding this comment.
forgot to comment this line..
|
@ishudohare , that's not how open source contribution works. If everyone starts solving all the issues in the same PR, there's no point in open source contribution then. So, for a single issue send a single PR. |
|
Okay..got it, I just started open source, so i guess I will learn from my mistakes. |
3 participants
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.