✨ - feat: multi-select #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| &__pill { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| padding: 0 0.5em; // TODO: spacing-h and spacing-v are too big for this. Add more tokens or hardcode? |
There was a problem hiding this comment.
Hardcode is OK for now.
| hidden={true} | ||
| aria-label="" // Intentionally left blank | ||
| multiple={multiple} | ||
| value={selectValue} |
There was a problem hiding this comment.
If there are multiple values, is the resulting (fake) select spec wise equivalant to a native multiple select? What will the value/options look like?
svenvandescheur
requested changes
May 22, 2025
There was a problem hiding this comment.
Looks like a nice start, todo:
- Update the story sample data to be more sensible.
- Add stories for the complete form flow.
- Adjust to the latest design from @ZoeReijinga , note: theme colors differences may be ignored.
- Add remove buttons to selected options.
svenvandescheur
force-pushed
the
issue/multi-select
branch
from
2f08256 to
51a3116
Compare
svenvandescheur
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Still in construction