Refactor: Phase 1 shared 레이어 구축 + Phase 1.5 웹 접근성 보강#1
Merged
Conversation
## Phase 0: 기반 구축
- Vitest + happy-dom 테스트 환경 설정
- Playwright E2E 설정
- Tailwind v4 설치 (Emotion 공존)
- FSD 디렉토리 스캐폴딩 (shared/entities/features/widgets)
- CLAUDE.md 리팩토링 가이드라인 문서 작성
## Phase 1: shared/ui 레이어 구축 (113개 테스트)
- Button 그룹: Button/FilterButton/ApplyListButton/CloseButton/EditAndDeleteButton/ReportButton
- ButtonContainer 3중복 제거, 컴포지션 패턴 적용
- CloseButton API: setIsOpen → onClick으로 변경
- Badge/Select/Tag/Text 그룹
- Input 그룹: RemoveButton/InputField/StateInputField/ValidationInputField/TextareaField/CodeInput/CommentInput
- Toast 그룹: BaseToast 추출, ErrorToast FSD 위반 제거 (스토어 어댑터 패턴)
- Modal 그룹: ModalDimmed/BaseModal/BottomSheetModal 추출, window.innerWidth → Tailwind 대체
- Profile: RoundedImage
- Emotion → Tailwind 전환, 하위 호환 re-export 유지
- 버그 수정 7건 (opacity:0px, clip-path camelCase, white-space 문자열 등)
## Phase 1.5: 웹 접근성 보강 (134개 테스트)
- jest-axe 도입, setup.ts 전역 등록
- RemoveButton: aria-label="삭제"
- CloseButton: aria-label prop 추가
- Select: role=combobox/listbox/option, aria-expanded, aria-haspopup, aria-selected
- StateInputField: aria-describedby 에러메시지 연결 (errorMessageId prop)
- CodeInput: 각 셀 aria-label="{n}번째 숫자"
- BaseModal/BottomSheetModal: role=dialog, aria-modal, focus trap, Escape 닫기
## 기타 수정
- 개발 서버 포트 9999 → 8080 (백엔드 CORS 허용 목록 대응)
- next.config.js rewrites 프록시 추가 (CORS 우회)
- src/api/index.ts: MAX_RETRY_COUNT 50 → 5, 클라이언트/서버 baseURL 분기
- globals.css CSS 리셋 전체 @layer base로 이동 (Tailwind utilities 우선순위 보장)
- src/pages/ 디렉토리 제거 (Next.js Pages Router 충돌 방지)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Vercel 환경에서 API_BASE_URL 환경변수가 없을 경우 rewrites destination이 "undefined/api/:path*"가 되어 빌드가 실패하는 문제 수정. 환경변수가 없으면 rewrites를 빈 배열로 반환. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Button/ApplyListButton에 deprecated addStyle prop 추가 (style의 alias) - Terms.tsx disabled Button의 중복 addStyle 제거 - MyPage.tsx onClick 타입 불일치 수정 (MouseEvent → 타입 추론) - stories의 잘못된 CSS weight 프로퍼티 → fontWeight로 수정 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vercel.json 없이 배포 시 Vite로 감지되어 dist 폴더를 찾는 문제 수정. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
anthropics/claude-code-action이 OIDC 토큰 발급에 필요한 권한. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CHROMATIC_PROJECT_TOKEN 없이 매번 실패하는 Chromatic CI 제거. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
anthropics/claude-code-action@v1에서 direct_prompt는 유효하지 않은 입력. 올바른 파라미터명은 prompt. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
components/designSystem/의 31개 컴포넌트를 FSD 구조의shared/ui/로 이전하고, 웹 접근성을 보강했습니다.Phase 0: 기반 구축
CLAUDE.md리팩토링 가이드라인 문서 작성Phase 1: shared/ui 레이어 (113개 테스트)
opacity: 0px,clip-pathcamelCase,white-space문자열 등)Phase 1.5: 웹 접근성 보강 (134개 테스트)
jest-axe도입 — 자동 WCAG 검사RemoveButton:aria-label="삭제"CloseButton:aria-labelpropSelect:role=combobox/listbox/option,aria-expanded,aria-selectedStateInputField:aria-describedby에러메시지 연결CodeInput: 셀별aria-label="{n}번째 숫자"BaseModal/BottomSheetModal:role=dialog,aria-modal, focus trap, Escape 닫기기타
9999 → 8080(백엔드 CORS 대응)next.config.jsrewrites 프록시 추가 (CORS 우회)src/api/index.tsMAX_RETRY_COUNT50 → 5globals.cssCSS 리셋 전체@layer base로 이동 (Tailwind utilities 우선순위 보장)src/pages/삭제 (Next.js Pages Router 충돌 방지)테스트
🤖 Generated with Claude Code