Skip to content

Conversation

@slctr
Copy link

@slctr slctr commented May 22, 2020

Could someone said, why the solution is not well?

Amazing, Reviewer said, that in my code:

  1. Missed in some places encapsulation. Where? For constants? Really?
  2. Style code. No words.
  3. Not used 'D' from SOLID. WTF?! Why should I use here DI or more abstractions than interfaces for so simple algorithm? What about KISS?

Please, someone leave comments in theme what do you think is not so well, really bad or what Reviewer wanted to say when left such words about my source code.

Thank you,
Edgar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant