Skip to content

fixes compilation warnings on Elixir 1.10 and 1.11 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaimeiniesta wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes compilation warnings on Elixir 1.10 and 1.11 #9

jaimeiniesta wants to merge 2 commits into from

Conversation

@jaimeiniesta
Copy link
Contributor

@jaimeiniesta jaimeiniesta commented May 26, 2021 •
edited
Loading

Hello!

This PR fixes compilation warnings:

Elixir 1.10

private functions can't have @doc, so instead I converted them to comments.

Elixir 1.11

Please remove the duplicate docs. If instead you want to override a previously defined @doc, attach the @doc attribute to a function head:

@jaimeiniesta jaimeiniesta changed the title fixes warnings about @doc attribute is always discarded for private fixes compilation warnings on Elixir 1.10 and 1.11 May 27, 2021
@jaimeiniesta jaimeiniesta mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaimeiniesta