feat: migrate GasEducationCarousel from JS to TypeScript#20
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: migrate GasEducationCarousel from JS to TypeScript#20devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Convert index.js to index.tsx - Replace PropTypes with TypeScript interfaces - Replace connect HOC with useSelector hooks - Add proper type annotations for all variables and functions - Type navigation and route props using @react-navigation/native types - Type gas estimation logic with proper BN types - Update test file with proper TypeScript mocks - Ensure strict TypeScript compliance Co-Authored-By: mason.batchelor@windsurf.com <mason.batchelor@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: migrate GasEducationCarousel from JS to TypeScript
Summary
Migrated the
GasEducationCarouselcomponent from JavaScript to TypeScript as part of the ongoing JS→TS migration effort. This PR includes:index.js→index.tsxconnectHOC withuseSelectorhooks@react-navigation/nativetypes for navigation and route propsKey changes include creating a
GasEducationCarouselPropsinterface, typing the complex gas estimation algorithm with proper BN types, and ensuring strict TypeScript compliance throughout.Review & Testing Checklist for Human
navigation.pop()tonavigation.goBack())Notes
The most significant architectural change is replacing the
connectHOC pattern with modernuseSelectorhooks. The gas estimation logic includes complex BigNumber operations that now have proper typing - this is critical functionality that should be tested thoroughly.Link to Devin run: https://app.devin.ai/sessions/6d58bef36223461ea9a83fd1e01c9a64
Requested by: @mbatchelor81