feat: migrate GasEducationCarousel component to TypeScript#22
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: migrate GasEducationCarousel component to TypeScript#22devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Rename index.js to index.tsx for JSX support - Replace PropTypes with TypeScript interface GasEducationCarouselProps - Add proper type annotations for state variables (currentTab, gasFiat, isLoading) - Type function parameters in onChangeTab and renderText - Add navigation typing using NavigationProp and ParamListBase - Export component for testing and maintain Redux connection - Update test file to use exported component with proper props - Fix TypeScript compilation errors and maintain functionality Follows established migration patterns from OnboardingCarousel and PickComponent components. Co-Authored-By: mason.batchelor@windsurf.com <mason.batchelor@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: migrate GasEducationCarousel component to TypeScript
Summary
Migrates the
GasEducationCarouselcomponent from JavaScript to TypeScript following established patterns in the codebase. This is part of the ongoing JS→TS migration effort for MetaMask Mobile.Key changes:
index.js→index.tsxfor JSX supportGasEducationCarouselProps@react-navigation/nativeand@metamask/design-tokensestimatedGasLimitHexproperty to gas fee calculationsnavigation.pop()tonavigation.goBack()Review & Testing Checklist for Human
🔴 Critical (3 items):
navigation.goBack()behaves the same as the previousnavigation.pop()when dismissing the carouselestimatedGasLimitHexproperty might affect calculations)Notes
anytypes were used as temporary workarounds (state: any,connectcasting) - these could be improved in a follow-up PR for better type safetystyles.scrollTabsfrom ScrollableTabView component - verify this doesn't affect visual appearanceLink to Devin run: https://app.devin.ai/sessions/cf70e28dde194d70be29af7be08bcc7e
Requested by: @mbatchelor81