Open
Conversation
Added experimental pattern to the end of ENCODING_REGEX intended to match data-react-helmet charset used on Musixmatch.
Author
|
I managed to install msbuild and compile this change (with YamlDotNet.11.1.0, NUnit.3.13.1, and, ILMerge.3.0.41) and it succeeded and works fine. However, I realize now that Musixmatch has bot detection, so the issue is probably from the captcha page and not a failure due to charset detection. The added regex makes it more robust, but doesn't seem to fix the provider completely and may be unnecessary. |
|
The change is still valid though, but the regex is more specific then it needs to be. The data-react attribute is not necessary and should not be required here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe I found the cause of the Musixmatch provider saying "lyrics found" but then returning an empty result. You referenced it in this thread: https://getmusicbee.com/forum/index.php?topic=25406.msg185630#msg185630
It seems Musixmatch is not including any of the normal character set information in the header, and so the ENCODING_REGEX match is failing. I think leads to an uncaught error on line 259.
I added a pattern to the end of ENCODING_REGEX intended to match data-react-helmet charset used on Musixmatch. I do not currently have the ability to compile and test this change, but I hope this suggestion is helpful.