Improved color bindings and support for all keywords of current i3 specifications.#38
Open
litoj wants to merge 48 commits intomboughaba:masterfrom
Open
Improved color bindings and support for all keywords of current i3 specifications.#38litoj wants to merge 48 commits intomboughaba:masterfrom
litoj wants to merge 48 commits intomboughaba:masterfrom
Conversation
Author
|
The edits in README are mainly for myself, those were not supposed to go to the request, but I don't know how to remove a file from the request. |
|
Please consider making changes to the upstream vim repo directly as this code is there as of vim/vim@8176be1 |
|
@JosefLitos offer still stands to commit to the vim repo directly and make your changes available to everyone, including every other Arch Linux users. |
Author
|
I may give it a try soon, if all goes as planned. |
Author
|
@hiqua thanks for reminding me, should be ready to go, just made a couple more fixes: |
litoj
force-pushed
the
master
branch
4 times, most recently
from
121778e to
0831d34
Compare
this is a correction of vim/vim#18293 + implementation of vim/vim#18760
This is preventing us from using default highlight link for the syntax keyword.
So that we only changed the highlight for popup fullscreen opts and the opts extra will also changed.
feat: link highlight popup fullscreen opts extra with opts
This is an implementation of vim/vim#18814. All code regarding identifiers was updated to have a unanymous style. All identifiers are now highlighted with their own group, linking to `i3ConfigIdent`. Co-Authored-By: Konstantin Pospelov <kupospelov@gmail.com>
Co-authored-by: Felix Pehla <29adc1fd92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to contribute my additions to the syntax to support all keywords i3 has right now.
I also notably changed color bindings to provide a more pg-language-like experience. More color links are used and newly I added a better highlighting conditions.
This makes it possible for more colors to be used and people can distinguish more different functions.