Conversation
Have to "Source" it for now, after dynamically loading RMorphy.dll, because the package can't compile the MorphyLib source.
cdesjardins
reviewed
Mar 10, 2018
| @@ -28,7 +28,7 @@ typedef double Mflt; | |||
| typedef unsigned int MPLstate; | |||
|
|
|||
| #define NA ((MPLstate)0b1) | |||
Collaborator
There was a problem hiding this comment.
Just a quick comment, not that you guys care, but typically I like to prefix things like this, it makes the code more greppable. Try and grep the codebase for NA and see what you get... If it was something like MORPHY_NA, or MFL_ISMISSING etc... then it doesn't get lost so easily.
Collaborator
There was a problem hiding this comment.
Funny, I just read the comment on why the MISSING define was changed to ISMISSING... that is yet another reason to have prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am encountering a warning when using MorphyLib in R (i.e. copying the source files to my
inapplicablepackage), because R defines a variableMISSINGin its own header files, so when the Morphy library headers are called,MISSINGis already defined.An easy way to avoid this conflict would be to rename
MISSINGtoISMISSING, as I've suggested here; perhapsMPLMISSINGwould be better still.