feat: Add service day column to output tables; Support all subway terminals #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to stop using parent station IDs as terminals because Ashmont counts as two separate terminals-- Red Line southern terminal, and Mattapan Trolley northern terminal
… control for selecting terminals
jzimbel-mbta
requested review from
a team and
cmaddox5
and removed request for
a team
jzimbel-mbta
commented
Jan 23, 2025
Member
Author
There was a problem hiding this comment.
The API for custom live Kinos weirdly does not have direct support for html assets or (h)eex templates.
I do think I could have built the elements a bit more concisely, but this works well enough... 🤷♂️
Happy to try a pseudo-template-based approach if this code seems unacceptably verbose to you.
There was a problem hiding this comment.
It's easy to follow so this is fine with me!
… made to the file in vscode
cmaddox5
approved these changes
Jan 23, 2025
cmaddox5
left a comment
cmaddox5
left a comment
There was a problem hiding this comment.
Geez, Ashmont really making you work. This looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: 📓 Misc. transit data report notebook updates
A big sticking point in implementing this seemingly benign change was that Ashmont now counts as two different terminals—one for the Red Line and one for the Mattapan Trolley.
I had previously been using parent station IDs (e.g.
place-asmnl) to uniquely identify terminals, but this no longer worked for that specific case.So I had to do a pretty big refactor to separate the concept of a terminal from the concept of a parent station ID.