feat: Support analysis over multiple service days #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzimbel-mbta
requested review from
a team and
meagharty
and removed request for
a team
meagharty
approved these changes
Jan 30, 2025
meagharty
left a comment
meagharty
left a comment
There was a problem hiding this comment.
Looks good to me! I appreciate the tidying effort too
| {terminals, stop_groups} = GlidesReport.Terminal.all_labeled_terminals_and_groups() | ||
| terminal_ids_input = GlidesReport.TerminalSelection.new(terminals, stop_groups) | ||
| {terminals, groups} = GlidesReport.Terminal.all_labeled_terminals_and_groups() | ||
| terminal_ids_input = TransitData.GlidesReport.TerminalSelection.new(terminals, groups) |
There was a problem hiding this comment.
nit: does this need the TransitData prefix?
Member
Author
There was a problem hiding this comment.
Oops, no it does not.
(I wish Credo could scan .livemd files...)
|
|
||
| sample_rate_input = | ||
| Kino.Input.range("Sample data at (?)-minute intervals", min: 1, max: 5, step: 1, default: 5) | ||
| Kino.Input.range("Sample data at (?)-minute intervals", min: 1, max: 5, step: 1, default: 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana ticket: 📓 Misc. transit data report notebook updates
Crissy doesn't need to analyze part of a service day or days, so I removed the code related to that, reducing complexity a bit.
You can use any value as a map key in Elixir, which saved me a bunch of effort since I didn't have to constantly convert DateTimes to and from strings 😮💨